Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yishay Amir #11

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Yishay Amir #11

wants to merge 18 commits into from

Conversation

yisha23
Copy link

@yisha23 yisha23 commented Nov 20, 2023

No description provided.

@levyishai levyishai changed the title sideShooterConstantas Yishai Amir Nov 20, 2023
@yisha23 yisha23 changed the title Yishai Amir Yishay Amir Dec 4, 2023
Copy link
Member

@levyishai levyishai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little hard one. I want you to add a couple of commands (they can all have the same name - a little something called overloading).

A command that accepts the target positon for each mechanism and not state.
Another one that accepts the target position and two "speed percentages", each for each mechanism. These will change the constraints of the profile according to the percentage (you can use a function from conversions called scaleConstraints). This will require some restructuring.
A command that accepts a target state and two speed percentages.
All of these can be "built on each other"
If you make the second command, you can just make all the other commands call it and return its value.

src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
src/main/java/frc/trigon/robot/subsystems/arm/Arm.java Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants