Merge pull request #41 from boherm/ignore-dependabot-prs

PrestaShop · Jun 3, 2024 · 7ed48b7 · 7ed48b7
2 parents 14b6335 + 5ad8eb5
commit 7ed48b7
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/src/PullRequest/Application/CommandHandler/WelcomeNewContributorCommandHandler.php b/src/PullRequest/Application/CommandHandler/WelcomeNewContributorCommandHandler.php
@@ -19,6 +19,11 @@ public function __construct(
 
     public function __invoke(WelcomeNewContributorCommand $command): void
     {
+        // We ignore dependabot PRs.
+        if ('dependabot[bot]' === $command->contributor) {
+            return;
+        }
+
         // We check if the committer is a new contributor.
         if ($this->committerRepository->isNewContributor($command->repositoryOwner, $command->repositoryName, $command->contributor)) {
             // If it is, we add a comment to the PR.

diff --git a/tests/PullRequest/Application/CommandHandler/WelcomeNewContributorCommandHandlerTest.php b/tests/PullRequest/Application/CommandHandler/WelcomeNewContributorCommandHandlerTest.php
@@ -34,7 +34,7 @@ protected function setUp(): void
     /**
      * @dataProvider provideTestHandle
      */
-    public function testHandle(PullRequestId $pullRequestId, bool $newContributor, bool $expectedComment): void
+    public function testHandle(PullRequestId $pullRequestId, string $contributor, bool $newContributor, bool $expectedComment): void
     {
         $this->prRepository->feed([
             PullRequest::create(
@@ -60,12 +60,12 @@ public function testHandle(PullRequestId $pullRequestId, bool $newContributor, b
             repositoryOwner: $pullRequestId->repositoryOwner,
             repositoryName: $pullRequestId->repositoryName,
             pullRequestNumber: $pullRequestId->pullRequestNumber,
-            contributor: 'fakeContributor',
+            contributor: $contributor,
         ));
     }
 
     /**
-     * @return array<array<int, PullRequestId|bool>>
+     * @return array<array<int, PullRequestId|bool|string>>
      */
     public static function provideTestHandle(): array
     {
@@ -76,6 +76,7 @@ public static function provideTestHandle(): array
                     repositoryName: 'fake',
                     pullRequestNumber: 'fake'
                 ),
+                'fakeContributor',
                 false,
                 false,
             ],
@@ -85,6 +86,7 @@ public static function provideTestHandle(): array
                     repositoryName: 'fake',
                     pullRequestNumber: 'fake'
                 ),
+                'fakeContributor',
                 true,
                 true,
             ],
@@ -94,6 +96,7 @@ public static function provideTestHandle(): array
                     repositoryName: 'PrestaShop',
                     pullRequestNumber: 'pullRequestNumber'
                 ),
+                'fakeContributor',
                 false,
                 false,
             ],
@@ -103,9 +106,20 @@ public static function provideTestHandle(): array
                     repositoryName: 'PrestaShop',
                     pullRequestNumber: 'pullRequestNumber'
                 ),
+                'fakeContributor',
                 true,
                 true,
             ],
+            [
+                new PullRequestId(
+                    repositoryOwner: 'PrestaShop',
+                    repositoryName: 'PrestaShop',
+                    pullRequestNumber: 'pullRequestNumber'
+                ),
+                'dependabot[bot]',
+                true,
+                false,
+            ],
         ];
     }
 }