Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 #406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add PHP 8.4 #406

wants to merge 1 commit into from

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 19, 2024

Questions Answers
Description? Add PHP 8.4
Type?
BC breaks?
Deprecations?
Fixed ticket?
Sponsor company
How to test?

@ps-jarvis
Copy link

Hello @Hlavtox!

This is your first pull request on docker repository of the PrestaShop project.

Thank you, and welcome to this Open Source community!

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 19, 2024

Ping @Progi1984 @nesrineabdmouleh

@Progi1984
Copy link
Member

Not out scope. Ping @PrestaShop/tech-council

@SharakPL
Copy link
Contributor

SharakPL commented Nov 20, 2024

Maybe we could simplify installation a bit with https://github.com/mlocati/docker-php-extension-installer
I simply use this in the Dockerfile:

ADD --chmod=0755 https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions /usr/local/bin/

RUN install-php-extensions gd imagick bcmath intl pdo_mysql mysqli zip memcached xdebug

Although few packages are not yet ready for PHP 8.4 eg. imagick
An update 2 days ago fixed that and all needed extensions are available.

Copy link
Contributor

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for this but I block for now, we first need to test the core compatibility with PHP 8.4 before we release new dockers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

5 participants