Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to model_config #16562

Merged
merged 4 commits into from
Jan 1, 2025
Merged

Add typing to model_config #16562

merged 4 commits into from
Jan 1, 2025

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Dec 31, 2024

In the spirit of #16292, this PR addresses 63 of the 868 outstanding isTypeAmbiguous pyright errors.

class Thing(BaseModel):
    model_config: ClassVar[ConfigDict] #needs this

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 31, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #16562 will not alter performance

Comparing configdict-typing (9507f3b) with main (5f5e4a6)

Summary

✅ 3 untouched benchmarks

zzstoatzz
zzstoatzz approved these changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zzstoatzz zzstoatzz merged commit 277731d into main Jan 1, 2025
38 checks passed
@zzstoatzz zzstoatzz deleted the configdict-typing branch January 1, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzstoatzz zzstoatzz zzstoatzz approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaazzam @zzstoatzz