-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mild CLI cleanup #16560
Open
aaazzam
wants to merge
15
commits into
main
Choose a base branch
from
cleanup-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
mild CLI cleanup #16560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaazzam
requested review from
cicdw,
desertaxle and
zzstoatzz
as code owners
December 31, 2024 19:05
CodSpeed Performance ReportMerging #16560 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #15008 and #16292, this PR
acommand
method to Prefect's Typer subclass to handle asynchronous CLI commands.This PR started getting big, so going to cap it here.
That said, some advances in Click/Typer/Pydantic since this was last touched obviates some of our design.
Aside from that, the directory structure should be revisited: the main
app
is defined incli/root.py
then imported intocli/__init__.py
from which every file incli
imports thatapp
and then attaches its local app to it. tl;dr couldn't get more circular if we tried.Given more time, I'd refactor into a single
app.py
that takes on responsibility for importing and doing the attaching and registration. Makes it easy to inspect the command space and ensure aliasing is done properly, etc.