DeploymentsDataTable - Part 1
#16355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
requested review from
aaazzam,
cicdw and
zzstoatzz
as code owners
|
spacing between the dot and the words "Not" and "Ready" are inconsistent. Is there a way to fix that? |
|
can we axe the box shadow on the ready / not ready? |
desertaxle
force-pushed
the
deployments-list
branch
from
cdea5cc to
8494f5f
Compare
aaazzam
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
DeploymentsDataTablecomponent. Not all columns are implemented as part of this PR (#16284 needs to be merged to add the activity column), and the table hasn't been wired up to a hook yet, but the interface for the component should be pretty set.I added a
StatusBadgecomponent also to support the 'Status' column in the table.Here's what it looks like so far:
Related to #15512