[UI v2] feat: Simplifies typography by introducing a simple typography component #16231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinvillarosa
commented
Dec 5, 2024
There was a problem hiding this comment.
could probably do this a bit more streamline in the future with createElement feature
devinvillarosa
force-pushed
the
common-typography-component
branch
from
ca2c1b9 to
936a5d9
Compare
devinvillarosa
requested review from
aaazzam,
cicdw,
desertaxle and
zzstoatzz
as code owners
devinvillarosa
force-pushed
the
common-typography-component
branch
from
936a5d9 to
fe7cb4c
Compare
desertaxle
approved these changes
Dec 5, 2024
| import { cn } from "@/lib/utils"; | ||
| import { forwardRef } from "react"; | ||
|
|
||
| type Variant = "h1" | "h2" | "h3" | "h4" | "bodyLarge" | "body" | "bodySmall"; |
There was a problem hiding this comment.
It'd be cool to follow a variant structure similar to Button using cva.
There was a problem hiding this comment.
I can look into it in a followup PR. Didn't know we had a library like that
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rebuilding UI pages, the typography can get confusing with the abundance of options provided with Tailwind.
This PR:
Checklist
<link to issue>"mint.json.Related to #15512