Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Starts page layout for concurrency page #16226

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[UI v2] feat: Starts page layout for concurrency page #16226

merged 1 commit into from
Dec 5, 2024

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Dec 5, 2024 •
edited
Loading

image

Adds basic page layout for concurrency page

  1. Create page layout component and place in some re-usable component fillers

Todos when doing this exercise:

  1. Create a re-usable component for the tab navigation
  2. Integrate routing url options to handle tab state
Screen.Recording.2024-12-05.at.3.36.47.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Related to #15512

@devinvillarosa devinvillarosa marked this pull request as ready for review December 5, 2024 00:28
@devinvillarosa devinvillarosa force-pushed the start-concurrency-page-layout branch 3 times, most recently from 1dc3860 to 469a91f Compare December 5, 2024 04:35
devinvillarosa
devinvillarosa commented Dec 5, 2024
View reviewed changes
ui-v2/src/components/layouts/MainLayout.tsx
import { Toaster } from "../ui/toaster";

export function MainLayout({ children }: { children: React.ReactNode }) {
return (
<SidebarProvider>
<AppSidebar />
<main className="flex-1 overflow-auto">{children}</main>
<main className="flex-1 overflow-auto p-4">{children}</main>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding p-4 so that all screens will render with the built in padding

@devinvillarosa devinvillarosa force-pushed the start-concurrency-page-layout branch from 469a91f to 037b4a9 Compare December 5, 2024 15:53
@devinvillarosa devinvillarosa marked this pull request as draft December 5, 2024 17:09
@devinvillarosa devinvillarosa force-pushed the start-concurrency-page-layout branch 2 times, most recently from 3006f65 to 60f9ab4 Compare December 5, 2024 23:52
@devinvillarosa devinvillarosa force-pushed the start-concurrency-page-layout branch from 60f9ab4 to c849f82 Compare December 5, 2024 23:52
@devinvillarosa devinvillarosa marked this pull request as ready for review December 5, 2024 23:53
@devinvillarosa devinvillarosa merged commit a8bb685 into main Dec 5, 2024
9 checks passed
@devinvillarosa devinvillarosa deleted the start-concurrency-page-layout branch December 5, 2024 23:55
devinvillarosa added a commit that referenced this pull request Dec 6, 2024
@devinvillarosa
[UI v2] feat: Starts page layout for concurrency page (#16226)
a4a17b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desertaxle desertaxle desertaxle approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @desertaxle