-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI v2] feat: Adding Icon component to consolidate available icons for the UI #16208
Conversation
875d258
to
b57ed9f
Compare
b57ed9f
to
aaba231
Compare
X, | ||
} as const; | ||
|
||
export type IconId = keyof typeof ICONS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Lucide not publish it's own Enum for this? Woooof.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, but they don't recommend using it because it drastically increased bundle size: https://lucide.dev/guide/packages/lucide-react#one-generic-icon-component
42181c5
to
1610f28
Compare
1610f28
to
1846742
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Icons used in the UI has an unlimited factor on which ones to use.
This PR consolidates which icons can be used for the UI by centralizing it all in the
Icon
componentlucide-react
Icons for our internal Icon libraryScreen.Recording.2024-12-03.at.8.56.54.PM.mov
Checklist
<link to issue>
"mint.json
.Discussed in comments #16203
Related to #15512