-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish openAPI yaml in ci/cd #15549
Conversation
🤦 The GH Action is writing but not persisting the file. |
I like the idea of doing this in CI so developers don't have to remember to generate this file before opening a PR! I don't think we have any GH workflows that commit files to a PR on the submitter's behalf, so we'll have to figure out how to do that. This example for the |
What do you think about creating a separate code/schema generation workflow? I see that it's currently in the static analysis workflow, but I'm not quite sure it fits there. |
@aaazzam I don't think building this in the static analysis CI job makes sense unless the goal is to test that it can be built successfully. If the goal is to publish this spec within the package, then I think the best way is probably:
|
@cicdw I avoided putting it in pre-commit at first b/c Will move this to pre-commit, and great call out on the package manifest. |
Closes #14970, by autogenerating an
openapi.yml
insrc/prefect/_internal
in thestatic_analysis
workflow.Eventually I'd like to make this a 'public' file, but starting in
_internal
while the only known use case is #15512, which will use this file inopenapi-ts
to autogenerate a fetching service layer for the UI.Briefly considered moving it to
pre-commit
, but doesn't seem appropriate.