Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB missing image warning #2326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ascholerChemeketa
Copy link
Contributor

Currently, if the packaging_tree that is built for an EPUB ends up with images that are missing a sourcename it results in a broken build. This is happening when I try to build the sample-book with -f epub-svg.

This produces warnings for each image that does not end up with the right information but allows the build to continue.

@rbeezer
Copy link
Collaborator

rbeezer commented Dec 27, 2024

results in a broken build

In what way? I get an EPUB that is readable by calibre and epubcheck (though the former is not always pretty and the latter has errors).

It appears to me that @sourcename really shouldn't be empty. Might it be better to get to the root of the problem?

@ascholerChemeketa
Copy link
Contributor Author

It looks like the cause of the images missing expected attributes are the ones injected into the source tree in the representations pass:

Should I turn this into an issue based on those images not meshing well with the packaging-info template?

@rbeezer
Copy link
Collaborator

rbeezer commented Dec 30, 2024

It looks like the cause of the images missing expected attributes are the ones

I was suspicious of that, and went looking, and I think I got distracted by some other rabbit holes...

Should I turn this into an issue based on those images not meshing well with the packaging-info template?

Yes, please! Don't get rid of this - the warning will be good for when we mess this up again. ;-)

@ascholerChemeketa
Copy link
Contributor Author

Issue created for root issue:
#2345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants