Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing captions above programs #2272

Conversation

ascholerChemeketa
Copy link
Contributor

This implements the "Runestone activecode steals caption of listing it is in" so that explaining text is placed inside RS box.

@rbeezer
It also moves listing caption above the listing in HTML output to match CMOS style. I don't trust my understanding of the LaTeX to update that output path. We could break this out separate, but it does improve the readability of listings, which benefit from some context before the reader hits a wall of text.

@rbeezer
Copy link
Collaborator

rbeezer commented Nov 2, 2024

I like the move of the heading/caption to the top. I'll need to mirror that change in LaTeX and braille.

I'm less enthusiastic about splitting the caption off from the heading and into the blue box. It feels "random" and not like a caption anymore. I would much rather see some work to accomodate Runestone components with more PreTeXt-y CSS for a less bold look-and-feel. Then maybe the heading/cpation would feel more attached and less disjoint. (That's a big project, but one I'd really like to see.)

If you feel strongly about the split, maybe host a live version of 5.1, post on -dev, and suggest a comparison with current website version. Solicit opinions.

@ascholerChemeketa
Copy link
Contributor Author

OK, I backed out the RS steals caption part. Having the caption above the activecode goes a long way to giving context to the listing. Still a potential issue if the listing is ever displayed out of context by RS, but that would only happen if someone assigned the listing as part of an assignment.

@ascholerChemeketa ascholerChemeketa changed the title Listing captions to activecodes Listing captions above programs Nov 6, 2024
@rbeezer
Copy link
Collaborator

rbeezer commented Nov 18, 2024

Original discussion on -dev was about titles. Code here seems to be about captions. They are different, and the code is likely as confused as the history. So getting this straight has never been easy. Look for a design discussion on -dev.

@rbeezer
Copy link
Collaborator

rbeezer commented Nov 19, 2024

code is likely as confused

Existing code! Not PR code. ;-)

@ascholerChemeketa ascholerChemeketa marked this pull request as draft November 19, 2024 16:16
@ascholerChemeketa
Copy link
Contributor Author

Closing in favor of:
#2299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants