Add mermaid support #750
Merged
Add mermaid support #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as a draft until accepted as part of core PreTeXt, but thanks for linking these up! |
|
This is making me think that part of our test suite should be building the sample article; that way we don't need extra tests for odds and ends like this that have passed Rob's muster already. |
Now part of PreTeXt. |
|
Y'know @ascholerChemeketa if you're handling mermaid, and I'm working on pelican, who's got Sebastian and Flounder? |
|
#758 includes a test of the sample article, so assuming there's Mermaid stuff there, let's get that merged to main first, then merge into here for a final integration test before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with this PR on PreTeXt: PreTeXtBook/pretext#2178