Skip to content

Commit

Permalink
UX Review (#27)
Browse files Browse the repository at this point in the history
Small text changes
  • Loading branch information
geoffwhittington authored May 3, 2018
1 parent 8c27b04 commit f455216
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public void perform(@Nonnull Run<?, ?> run, @Nonnull FilePath filePath, @Nonnull
run.addAction(new SDElementsRiskIndicatorBuildAction(riskIndicator, url, null));
throw new IllegalStateException("Improper connection selected. This is a required setting");
}
taskListener.getLogger().println("SD Elements compliance status: "+(riskIndicator == null ? "Undetermined" : riskIndicator));
taskListener.getLogger().println("SD Elements risk status: "+(riskIndicator == null ? "Undetermined" : riskIndicator));
run.addAction(new SDElementsRiskIndicatorBuildAction(riskIndicator, url, conn.getConnectionString()));
setBuildResult(markUnstable, riskIndicator, run);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public String getConnectionName() {

@Extension
public static class DescriptorImpl extends Descriptor<SDElementsConnection> {
public String getDisplayName() { return "SDElements connection"; }
public String getDisplayName() { return "SD Elements connection"; }

public ListBoxModel doFillCredentialsIdItems(final @AncestorInPath Item item, @QueryParameter String credentialsId) {
StandardListBoxModel lbm = new StandardListBoxModel();
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/index.jelly
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?jelly escape-by-default='true'?>
<div>
Jenkins integration for Security Compass SDElements tool
Jenkins integration for Security Compass SD Elements tool
</div>
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div>
The name of the connection to use
The name of the connection
</div>
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div>
When this checkbox is checked, non compliant results from an SD Element project will mark the build unstable instead of failing it
When this checkbox is checked, non compliant results from an SD Elements project will mark the build unstable instead of failing it
</div>
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div>
Connection url
Connection URL (for example: https://the.sdeserver.com)
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public void testPassingProject() throws Exception {
FreeStyleProject freeStyleProject = createProject("valid-connection", 1742, false);
FreeStyleBuild fsb = freeStyleProject.scheduleBuild2(0, new Cause.UserIdCause()).get();
jr.assertBuildStatus(Result.SUCCESS, fsb);
jr.assertLogContains("SD Elements compliance status: Pass", fsb);
jr.assertLogContains("SD Elements risk status: Pass", fsb);
}

@Test
Expand All @@ -81,7 +81,7 @@ public void testFailingProject() throws Exception {
FreeStyleProject fsp = createProject("valid-connection", 1739, false);
FreeStyleBuild fsb = fsp.scheduleBuild2(0, new Cause.UserIdCause()).get();
jr.assertBuildStatus(Result.FAILURE, fsb);
jr.assertLogContains("SD Elements compliance status: Fail", fsb);
jr.assertLogContains("SD Elements risk status: Fail", fsb);
}

@Test
Expand All @@ -91,7 +91,7 @@ public void testFailingProjectMarkAsUnstable() throws Exception {
FreeStyleProject fsp = createProject("valid-connection", 1739, true);
FreeStyleBuild fsb = fsp.scheduleBuild2(0, new Cause.UserIdCause()).get();
jr.assertBuildStatus(Result.UNSTABLE, fsb);
jr.assertLogContains("SD Elements compliance status: Fail", fsb);
jr.assertLogContains("SD Elements risk status: Fail", fsb);
}


Expand All @@ -102,7 +102,7 @@ public void testUndeterminedProject() throws Exception {
FreeStyleProject fsp = createProject("valid-connection", 1743, false);
FreeStyleBuild fsb = fsp.scheduleBuild2(0, new Cause.UserIdCause()).get();
jr.assertBuildStatus(Result.FAILURE, fsb);
jr.assertLogContains("SD Elements compliance status: Survey not completed", fsb);
jr.assertLogContains("SD Elements risk status: Survey not completed", fsb);
}

@Test
Expand Down

0 comments on commit f455216

Please sign in to comment.