Skip to content

Commit

Permalink
Merge pull request #472 from Praqma/improve-env-vars-validation
Browse files Browse the repository at this point in the history
don't validate env vars when files don't contain dollar signs
  • Loading branch information
Sami Alajrami authored May 15, 2020
2 parents 1f7eca3 + 559b427 commit 9bf332d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/app/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ func substituteEnv(name string) string {
// validateEnvVars parses a string line-by-line and detect env variables in
// non-comment lines. It then checks that each env var found has a value.
func validateEnvVars(s string, filename string) (bool, string) {
if !flags.skipValidation {
if !flags.skipValidation && strings.Contains(s, "$") {
log.Info("validating environment variables in " + filename)
var key string
comment, _ := regexp.Compile("#(.*)$")
Expand Down

0 comments on commit 9bf332d

Please sign in to comment.