refactor: linting

Signed-off-by: Luis Davim <[email protected]>

examples/composition/argo.yaml

@@ -13,6 +13,9 @@ namespaces:
         - name: "requests.nvidia.com/gpu"
           value: "2"
 
+helmRepos:
+  argo: "https://argoproj.github.io/argo-helm"
+
 apps:
   argo:
     namespace: "staging"

internal/app/spec_state.go

@@ -14,7 +14,7 @@ type StateFiles struct {
 	StateFiles []StatePath `yaml:"stateFiles"`
 }
 
-// fromYAML reads a yaml file and decodes it to a state type.
+// specFromYAML reads a yaml file and decodes it to a state type.
 // parser which throws an error if the YAML file is not valid.
 func (pc *StateFiles) specFromYAML(file string) error {
 	rawYamlFile, err := ioutil.ReadFile(file)
@@ -25,9 +25,5 @@ func (pc *StateFiles) specFromYAML(file string) error {
 
 	yamlFile := string(rawYamlFile)
 
-	if err = yaml.UnmarshalStrict([]byte(yamlFile), pc); err != nil {
-		return err
-	}
-
-	return nil
+	return yaml.UnmarshalStrict([]byte(yamlFile), pc)
 }

internal/app/spec_state_test.go

@@ -28,6 +28,13 @@ func Test_specFromYAML(t *testing.T) {
 				s:    new(StateFiles),
 			},
 			want: false,
+		}, {
+			name: "test case 3 -- Commposition example",
+			args: args{
+				file: "../../examples/composition/spec.yaml",
+				s:    new(StateFiles),
+			},
+			want: true,
 		},
 	}
 
@@ -66,9 +73,9 @@ func Test_specFileSort(t *testing.T) {
 			args: args{
 				files: fileOptionArray(
 					[]fileOption{
-						fileOption{"third.yaml", 0},
-						fileOption{"first.yaml", -20},
-						fileOption{"second.yaml", -10},
+						{"third.yaml", 0},
+						{"first.yaml", -20},
+						{"second.yaml", -10},
 					}),
 			},
 			want: [3]int{-20, -10, 0},