Merge pull request #524 from Praqma/helmsman_labels

fix: helm test resets release labels

Makefile

@@ -56,7 +56,7 @@ update-deps: ## Update depdendencies. Runs `go get -u` internally.
 	@GOFLAGS="" go mod tidy
 	@GOFLAGS="" go mod vendor
 
-build: vet deps ## Build the package
+build: deps vet ## Build the package
 	@go build -o helmsman -ldflags '-X main.version="${TAG}-${DATE}" -extldflags "-static"' cmd/helmsman/main.go
 
 generate:
@@ -65,6 +65,7 @@ generate:
 
 repo:
 	@helm repo list | grep -q "^stable " || helm repo add stable https://kubernetes-charts.storage.googleapis.com
+	@helm repo update
 .PHONY: repo
 
 test: deps vet repo ## Run unit tests

internal/app/plan.go

@@ -133,6 +133,12 @@ func releaseWithHooks(cmd orderedCommand, wg *sync.WaitGroup, sem chan struct{},
 		wg.Done()
 		<-sem
 	}()
+	if cmd.targetRelease == nil && !flags.destroy {
+		err := fmt.Errorf("nil target release")
+		errors <- err
+		log.Verbose(err.Error())
+		return
+	}
 	for _, c := range cmd.beforeCommands {
 		if err := execOne(c, cmd.targetRelease); err != nil {
 			errors <- err
@@ -145,16 +151,15 @@ func releaseWithHooks(cmd orderedCommand, wg *sync.WaitGroup, sem chan struct{},
 		log.Verbose(err.Error())
 		return
 	}
-	if cmd.targetRelease != nil && !flags.dryRun && !flags.destroy {
-		cmd.targetRelease.label()
-	}
 	for _, c := range cmd.afterCommands {
 		if err := execOne(c, cmd.targetRelease); err != nil {
 			errors <- err
 			log.Verbose(err.Error())
-			return
 		}
 	}
+	if !flags.dryRun && !flags.destroy {
+		cmd.targetRelease.label()
+	}
 }
 
 // execOne executes a single ordered command