Skip to content

Commit

Permalink
fix: add missing flags
Browse files Browse the repository at this point in the history
  • Loading branch information
Luis Davim committed May 14, 2021
1 parent b279eb3 commit 07a1b8b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/app/release.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func (r *release) diff() (string, error) {
cmd := CmdPipe{helmCmd(args, desc)}

if flags.kubectlDiff {
cmd = append(cmd, kubectl([]string{"diff", "-f", "-"}, desc))
cmd = append(cmd, kubectl([]string{"diff", "--namespace", r.Namespace, "-f", "-"}, desc))
}

res, err := cmd.RetryExec(3)
Expand Down Expand Up @@ -403,7 +403,7 @@ func (r *release) getHelmArgsFor(action string, optionalNamespaceOverride ...str
}
switch action {
case "template":
return concat([]string{"template", r.Name, r.Chart, "--version", r.Version, "--namespace", r.Namespace}, r.getValuesFiles(), r.getSetValues(), r.getSetStringValues(), r.getSetFileValues(), r.getPostRenderer())
return concat([]string{"template", r.Name, r.Chart, "--version", r.Version, "--namespace", r.Namespace, "--skip-tests", "--no-hooks"}, r.getValuesFiles(), r.getSetValues(), r.getSetStringValues(), r.getSetFileValues(), r.getPostRenderer())
case "install", "upgrade":
return concat([]string{"upgrade", r.Name, r.Chart, "--install", "--version", r.Version, "--namespace", r.Namespace}, r.getValuesFiles(), r.getSetValues(), r.getSetStringValues(), r.getSetFileValues(), r.getHelmFlags(), r.getPostRenderer())
case "diff":
Expand Down

0 comments on commit 07a1b8b

Please sign in to comment.