Feature/downloader #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
TonyXiang8787
previously approved these changes
Nov 3, 2022
|
We need more unit tests in order to merge this branch. @TonyXiang8787, we didn't really plan time for this story in this sprint. Would you like me (or someone else) to write unit tests for it? Or do we want to decrease the test coverage limit? |
bramstoeller
force-pushed
the
feature/downloader
branch
from
35cc728 to
2d1fa6b
Compare
bramstoeller
force-pushed
the
feature/downloader
branch
3 times, most recently
from
dc73d0e to
5f8f32a
Compare
bramstoeller
force-pushed
the
feature/downloader
branch
from
9bbd299 to
1e9d1b7
Compare
|
Looks good, had some minor comments. |
petersalemink95
previously approved these changes
Mar 6, 2023
bramstoeller
force-pushed
the
feature/downloader
branch
from
644915e to
3b6b20a
Compare
petersalemink95
previously approved these changes
Mar 7, 2023
Signed-off-by: Bram Stoeller <[email protected]>
Signed-off-by: Bram Stoeller <[email protected]>
Signed-off-by: Bram Stoeller <[email protected]>
Signed-off-by: Bram Stoeller <[email protected]>
Signed-off-by: Bram Stoeller <[email protected]>
…re supplied Signed-off-by: Bram Stoeller <[email protected]>
Signed-off-by: Bram Stoeller <[email protected]>
Signed-off-by: Bram Stoeller <[email protected]>
Signed-off-by: Bram Stoeller <[email protected]>
bramstoeller
force-pushed
the
feature/downloader
branch
from
3562c70 to
c9a25c8
Compare
petersalemink95
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.