Feature/gql2 566: PGM to GAIA conversion #282
Conversation
There was a problem hiding this comment.
Please remove the legacy Vision leftover from source
There was a problem hiding this comment.
including updating the docstring
| def __init__(self, source_file: Optional[Union[Path, str]] = None, language: str = "en"): | ||
| mapping_file = Path(str(DEFAULT_MAPPING_FILE).format(language=language)) | ||
| if not mapping_file.exists(): | ||
| raise FileNotFoundError(f"No Vision Excel mapping available for language '{language}'") | ||
| self._id_reference: Optional[IdReferenceFields] = None | ||
| source = VisionExcelFileStore(file_path=Path(source_file)) if source_file else None | ||
| super().__init__(mapping_file=mapping_file, source=source) |
There was a problem hiding this comment.
Please unify with other excel converters and make mapping_file a parameter
| if len(attr_data.columns) == 1: | ||
| pgm_data[attr] = attr_data.iloc[:, 0] | ||
| elif component == 'asym_load': | ||
| pgm_data[attr] = attr_data.iloc[:, 0:3] |
There was a problem hiding this comment.
| pgm_data[attr] = attr_data.iloc[:, 0:3] | |
| pgm_data[attr] = attr_data.iloc[:, :3] |
| p_nom: float, | ||
| wind_speed: float, | ||
| cut_in_wind_speed: float = 3.0, | ||
| nominal_wind_speed: float = 14.0, | ||
| cutting_out_wind_speed: float = 25.0, | ||
| cut_out_wind_speed: float = 30.0, | ||
| axis_height: float = 30.0, |
There was a problem hiding this comment.
including updating the docstring
| # r0: | ||
| # power_grid_model_io.functions.both_zeros_to_nan: | ||
| # value: R0 | ||
| # other_value: X0 | ||
| # x0: | ||
| # power_grid_model_io.functions.both_zeros_to_nan: | ||
| # value: X0 | ||
| # other_value: R0 | ||
| # c0: C0 |
There was a problem hiding this comment.
this file contains quite a significant amount of commented out lines. should those be removed?
|
Relates to #5 |
Files in the below folder are used to test the io. |
that's Alliander-internal data that cannot be shared outside (good thing it's not visible to people who don't have access to Alliander). Needs to be anonymized, randomized and reorganized to something that can be shared with other people. |
Idea for Gaia conversion, approach and modelling