Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recursor: building on system without libboost_thread #8464

Open
James-TR opened this issue Oct 24, 2019 · 3 comments
Open

recursor: building on system without libboost_thread #8464

James-TR opened this issue Oct 24, 2019 · 3 comments

Comments

@James-TR
Copy link
Contributor

James-TR commented Oct 24, 2019

  • Program: Recursor
  • Issue type: Bug report

Short description

Recursor is bringing in a dependency on libboost_thread even though it is not required on Linux. This is causing OpenWRT's build system to pick up an erroneous unwanted dependency that's only used in the Configure script.

Environment

  • Operating system: OpenWRT
  • Software version: 18.06
  • Software source: Self-compiled

Steps to reproduce

  1. Install the minimal required boost libraries to build recursor
  2. Run the build with standard configure options on linux
  3. Check to see if built files have a dependency on libboost_thread

Expected behaviour

Recursor would build without any missing library errors

Actual behaviour

Recursor build shows missing libboost_thread

Other information

OpenWRT removed a dependency from their libboost_context package on libboost_thread which caused this issue because the package stopped being brought in.

@pieterlexis
Copy link
Contributor

According to boost.m4:

# BOOST_CONTEXT([PREFERRED-RT-OPT], [ERROR_ON_UNUSABLE])
# -----------------------------------
# Look for Boost.Context.  For the documentation of PREFERRED-RT-OPT, see the
# documentation of BOOST_FIND_LIB above.
[...]
# * A dependency on boost_thread appears in 1.57.0
[...]

@James-TR
Copy link
Contributor Author

James-TR commented Oct 25, 2019

The boost.m4 check for boost_thread is incorrect, as this isn't linked where <mutex> is available.

Here's the relevant commit:
boostorg/context@01d3c90

And the lines of code in the version of boost OpenWRT is using:
https://github.com/boostorg/context/blob/boost-1.71.0/build/Jamfile.v2#L783-L789

@James-TR
Copy link
Contributor Author

I've opened an issue in the upstream boost.m4 repository tsuna/boost.m4#117

@omoerbeek omoerbeek added this to the rec-helpneeded milestone Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants