pdns-recursor missing dependency

[neheb]

https://downloads.openwrt.org/snapshots/faillogs/mipsel_24kc_24kf/packages/pdns-recursor/compile.txt

ping @James-TR

I'm curious about this dependency. I downloaded the source code and saw that it is not being used at all. It's only used in the configure script.

The failure is due to 260d4a3#diff-eda03f2256b0bcbeec4978a233231a89

And similarly, it's not used here either.

[James-TR]

That's a good point. I'll open an issue in the upstream project to see what their thoughts are.

PowerDNS/pdns#8464

[James-TR]

Hello @neheb

I've had an update from PowerDNS and it looks like boost_context has a dependency on boost_thread, which is mentioned in the upstream boost.m4 at https://github.com/tsuna/boost.m4/blob/master/build-aux/boost.m4

Here's the relevant snippet:

# BOOST_CONTEXT([PREFERRED-RT-OPT], [ERROR_ON_UNUSABLE])
# -----------------------------------
# Look for Boost.Context.  For the documentation of PREFERRED-RT-OPT, see the
# documentation of BOOST_FIND_LIB above.
#
# * This library was introduced in Boost 1.51.0
# * The signatures of make_fcontext() and jump_fcontext were changed in 1.56.0
# * A dependency on boost_thread appears in 1.57.0
# * The implementation details were moved to boost::context::detail in 1.61.0
BOOST_DEFUN([Context],
[boost_context_save_LIBS=$LIBS
 boost_context_save_LDFLAGS=$LDFLAGS
if test $boost_major_version -ge 157; then
  BOOST_THREAD([$1], [$2])
  m4_pattern_allow([^BOOST_THREAD_(LIBS|LDFLAGS)$])dnl
  LIBS="$LIBS $BOOST_THREAD_LIBS"
  LDFLAGS="$LDFLAGS $BOOST_THREAD_LDFLAGS"
fi

[James-TR]

But if you look in the actual library code you'll see there has been a check for <mutex> since 1.61.0 to use that instead of Boost::Thread where it is available.

https://github.com/boostorg/context/blob/boost-1.71.0/build/Jamfile.v2#L783-L789

[James-TR]

tsuna/boost.m4#117

[hnyman]

Any forthcoming fix for this error? (as right now the package does not compile at all)

Even a temporary fix?
Add the (actually unnecessary?) dependency to the package?

[James-TR]

I don't know why I didn't think of that as a stop gap. I'll whip up a PR tonight.