Support I2C request and add examples #115
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerBroker2
reviewed
Jul 3, 2024
| port->endTransmission(); | ||
|
|
||
| if (targetAddress < 0xFF) | ||
| port->endTransmission(); | ||
|
|
||
| return numBytesIncl; |
There was a problem hiding this comment.
@tommag I think if the target address is invalid, the function should return 0 since nothing was transferred. Maybe we could put everything dealing with port writing, port closing, and reporting numBytesIncl in the first if statement and return 0 otherwise
PowerBroker2
reviewed
Jul 3, 2024
|
|
||
| void I2C_RequestHandler(void) | ||
| { | ||
| myTransfer.replyWithDatum(testStruct); |
There was a problem hiding this comment.
@tommag I think it would be good to double check that the requested data length matches the struct the sender wants to report. There should be a check for this either at the sketch or lib level. Also, it might be nice to request a specific packet type (Packet ID field)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
Thanks for your work and sharing the lib !
I added new methods to handle I2C requestFrom functions. This allows to transfer data from I2C slave to I2C master as well as I2C 2-way communication.
Request and reply examples are provided and tested on Raspberry Pi Pico (but should work on all platforms)
Solves issues #81 and #106.