Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some cleanup in Transform. #59

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Some cleanup in Transform. #59

wants to merge 1 commit into from

Conversation

Possseidon
Copy link
Owner

  • Removed static create in favor of just using make_unique/make_shared.
  • Added implicit conversion from a dual quaternion.
  • Added a hint, that copying is currently disabled.
  • Made full_transform_ mutable.
  • Fixed some refs/consts.

@Possseidon Possseidon added dang-gl cleanup Some simple cleanup in the codebase labels Aug 27, 2021
@Possseidon Possseidon self-assigned this Aug 27, 2021
@Possseidon Possseidon force-pushed the dev/transform-cleanup branch 3 times, most recently from 786412d to 10e3189 Compare June 5, 2022 16:14
@Possseidon
Some cleanup in Transform.
a9a3257 
- Removed static create in favor of just using make_unique/make_shared.
- Added implicit conversion from a dual quaternion.
- Added a hint, that copying is currently disabled.
- Made full_transform_ mutable.
- Fixed some refs/consts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Possseidon Possseidon

Labels
cleanup Some simple cleanup in the codebase dang-gl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Possseidon