forked from phefley/burp-javascript-security-extension
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme, Correct Missing Driver File Issue, Correct Driver File Settings and Interface #1
Open
phefley
wants to merge
10
commits into
PortSwigger:master
Choose a base branch
from
phefley:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: build.gradle renamed: javascript-security-extension-all-1.1.jar -> javascript-security-extension-all-1.1.1.jar modified: src/main/java/org.focalpoint.isns.burp.srichecks/DriverServiceManager.java
Corrected issues when the chromedriver path was not available at start modified: javascript-security-extension-all-1.1.1.jar modified: src/main/java/org.focalpoint.isns.burp.srichecks/DriverServiceManager.java
renamed: javascript-security-extension-all-1.1.1.jar -> javascript-security-extension-all-1.1.2.jar modified: src/main/java/burp/BurpExtender.java modified: src/main/java/org.focalpoint.isns.burp.srichecks/PluginConfigurationTab.java
settings. modified: javascript-security-extension-all-1.1.2.jar modified: src/main/java/burp/BurpExtender.java modified: src/main/java/org.focalpoint.isns.burp.srichecks/DriverServiceManager.java
Added changes to address issue phefley#2 for the chromedriver setting falling back to default at each load. This is now stored as a setting in burp preferences. |
cross-domain (DOM) issue. Updated tests modified: .gitignore modified: build.gradle deleted: javascript-security-extension-all-1.1.2.jar modified: src/main/java/burp/BurpExtender.java modified: src/main/java/org.focalpoint.isns.burp.srichecks/ScriptFinder.java modified: src/test/java/org/focalpoint/isns/burp/srichecks/ScriptFinderTest.java
Try to obtain any headers available from the request and set cookies, where present. modified: build.gradle modified: src/main/java/burp/BurpExtender.java modified: src/main/java/org.focalpoint.isns.burp.srichecks/ScriptFinder.java
Addressed issues with chromedriver binaries not loading and causing the extension to be unusable. modified: build.gradle modified: src/main/java/org.focalpoint.isns.burp.srichecks/DriverServiceManager.java modified: src/main/java/org.focalpoint.isns.burp.srichecks/PluginConfigurationTab.java
field modified: src/main/java/org.focalpoint.isns.burp.srichecks/PluginConfigurationTab.java
Issues fix mar 2022
Fixed issues where it was not possible to set the driver path location. |
phefley
changed the title
Update Readme and Correct Missing Driver File Issue
Update Readme, Correct Missing Driver File Issue, Correct Driver File Settings and Interface
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!! The readme incorrectly mentioned CORS and should have mentioned CSP. Also, users were encountering issues when the chromedriver file was not present due to null pointer issues. Exception handling was corrected. Thank you!