Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cookie cached on disk bcheck #81

Merged

Conversation

domwhewell-sage
Copy link
Contributor

No description provided.

Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd recommend that you change your regex match string to "(?i)Set-Cookie:.+(expires=[\w\d\s:,]+;|max-age=\d+;).*".

This will make it case-insensitive (so if a response contains "Expires" rather than "expires" it will still match), and if there is no further content after the expires/max age attributes, this will still match.

@domwhewell-sage
Copy link
Contributor Author

Thank you for the suggestions! Changes have been made

Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Hannah-PortSwigger Hannah-PortSwigger merged commit e1e551b into PortSwigger:main Aug 11, 2023
@michael-eaton-portswigger

@domwhewell-sage As a contributor to our GitHub repository, we would like to invite you to our closed Discord community.

It is a place where passionate Burp users, including people who directly work on building and developing Burp here at PortSwigger, can talk about the tooling and web security in general.

If you would like to join, please email us at [email protected] and we will send over an invite link.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants