Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the "Hidden Input Field Detection at Response Level (Passive)" Finding #231

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

LabMC
Copy link
Contributor

@LabMC LabMC commented Sep 27, 2024

Overview

  • CONTEXT: The purpose of this request is to update the "vulnerability-classes/injection/Detecting hidden input fields for XSS.bcheck" URL.
  • The current version of this bcheck only checks if <input> has type="hidden" as its very first attribute.
  • The current version of this bcheck also does not consider hidden fields via style="display: none;"
  • I've also provided additions to the detail & remediation text which provides an easy example for how users should test Hidden Input findings for XSS.

Ask: As this is a significant update to a pre-existing bcheck file, please let me know what the correct syntax is for multiple authors.

BCheck Contributions

  • BCheck compiles and executes as expected
  • BCheck contains appropriate metadata (name, version, author, description and appropriate tags)
  • Only .bcheck files have been added or modified
  • BCheck is in the appropriate folder
  • PR contains single or limited number of BChecks (Multiple PRs are preferred)
  • BCheck attempts to minimize false positives

- Updated regex to look for type="hidden" in an input field wherever it is in that hidden HTML element.
- Included detection for style="display: none;"
- Updated descriptions for detail & remediation.
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additional validation that you've added to this BCheck.

We have some feedback around the styling of the issue detail and remediation advice to make this easier to read.

Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Hannah-PortSwigger Hannah-PortSwigger merged commit d49dba9 into PortSwigger:main Oct 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants