Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client_secret.bcheck #220

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Added client_secret.bcheck #220

merged 4 commits into from
Jul 26, 2024

Conversation

LabMC
Copy link
Contributor

@LabMC LabMC commented Jul 17, 2024

BCheck Contributions

  • The "client_secret.bcheck" file has been created to detect for the "client_secret", "client_id", & "refresh_token" OAuth API variables, plus variants of "api-key", within front-end files. This file is placed in the other/API folder.
  • Minor update to Content-Security-Policy.bcheck to look for findings in .js & .css files.
  • BCheck compiles and executes as expected
  • BCheck contains appropriate metadata (name, version, author, description and appropriate tags)
  • Only .bcheck files have been added or modified
  • BCheck is in the appropriate folder
  • PR contains single or limited number of BChecks (Multiple PRs are preferred)
  • BCheck attempts to minimize false positives

Removed .js from extensions blacklist.
Added .bcheck file.
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the submission! Looks really good. Minor comments above.

other/APIs/client_secret.bcheck Outdated Show resolved Hide resolved
other/APIs/client_secret.bcheck Outdated Show resolved Hide resolved
other/APIs/client_secret.bcheck Outdated Show resolved Hide resolved
other/APIs/client_secret.bcheck Outdated Show resolved Hide resolved
other/APIs/client_secret.bcheck Outdated Show resolved Hide resolved
Added changes based on feedback from "PortSwiggerWiener".
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the revisions.

Looks good 👍

Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Hannah-PortSwigger Hannah-PortSwigger merged commit fb15207 into PortSwigger:main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants