-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detection of SameSite disabled #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Really minor comments:
- Can you indent the metadata elements with 4 spaces so it's consistent throughout
- Within the detail and remediation you could use a standard "string" instead of the interpolated
string
.
Otherwise looks good. 👍
Thanks a lot for your feedback, I applied all your feedback. Feel free to reach if I missed something 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! 👍
You are welcome, thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me too
Thank you very much 😃 |
@righettod As a contributor to our GitHub repository, we would like to invite you to our closed Discord community. It is a place where passionate Burp users, including people who directly work on building and developing Burp here at PortSwigger, can talk about the tooling and web security in general. If you would like to join, please email us at [email protected] and we will send over an invite link. Thank you! |
Hello,
This PR propose a script to detect when a cookie disable the SameSite protection by setting the value to
None
.The objective of the script is to raise a information notice to allow to investigate to see if an CSRF attack can be used due to this settings.
Thanks you very much in advance for your feedback 😃