Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add apache shiro vuln check #109

Merged
merged 2 commits into from
Sep 14, 2023
Merged

add apache shiro vuln check #109

merged 2 commits into from
Sep 14, 2023

Conversation

QdghJ
Copy link
Contributor

@QdghJ QdghJ commented Sep 12, 2023

olliewuk
olliewuk suggested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@olliewuk olliewuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, thank you for the amazing contribution.

Can we ask please for the following changes before we merge?

  • Clean up the two .txt files
  • Split the key cracking .bcheck into its own PR and put int he /CVEd/ directory
  • Leave the remaining two BChecks in /other/ as this PR

This is so we maintain repo hygiene.

Thank you in advance from all at PortSwigger.

@QdghJ
Copy link
Contributor Author

QdghJ commented Sep 13, 2023

Firstly, thank you for the amazing contribution.

Can we ask please for the following changes before we merge?

  • Clean up the two .txt files
  • Split the key cracking .bcheck into its own PR and put int he /CVEd/ directory
  • Leave the remaining two BChecks in /other/ as this PR

This is so we maintain repo hygiene.

Thank you in advance from all at PortSwigger.

I can accept these changes. output.txt is used to locate the original key corresponding to the encrypted 'rememberMe' value. However, in future updates, I can include them in comments for easier reference. Thank you.

olliewuk
olliewuk approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@olliewuk olliewuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for that.

PortSwiggerWiener
PortSwiggerWiener approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@PortSwiggerWiener PortSwiggerWiener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the changes and your patience 👍

@PortSwiggerWiener PortSwiggerWiener merged commit 8525389 into PortSwigger:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PortSwiggerWiener PortSwiggerWiener PortSwiggerWiener approved these changes

@olliewuk olliewuk olliewuk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QdghJ @olliewuk @PortSwiggerWiener