Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore any "track" events which occur before "start". #585

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ignore any "track" events which occur before "start". #585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7749a03
Ignore any "track" events which occur before "start".
bicknellr Nov 18, 2020
18a8aab
Ignore any "track" events which occur before "start" in `_trackEnd`.
bicknellr Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app-drawer/app-drawer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,11 @@ Polymer({
},

_trackMove: function(event) {
if (!this._trackDetails) {
// Ignore any "track" events which occur before "start".
return;
}

this._translateDrawer(event.detail.dx + this._translateOffset);

// Use Date.now() since event.timeStamp is inconsistent across browsers
Expand All @@ -376,6 +381,11 @@ Polymer({
},

_trackEnd: function(event) {
if (!this._trackDetails) {
// Ignore any "track" events which occur before "start".
return;
}

var x = event.detail.dx + this._translateOffset;
var drawerWidth = this.getWidth();
var isPositionLeft = this.position === 'left';
Expand Down