Skip to content

Commit

Permalink
Merge pull request #370 from PolymerElements/console-warn
Browse files Browse the repository at this point in the history
Don't use this._warn
  • Loading branch information
frankiefu authored Oct 25, 2016
2 parents 22f2f94 + f6cf593 commit 3e0d398
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions app-scroll-effects/app-scroll-effects-behavior.html
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@
if ((effectDef = Polymer.AppLayout._scrollEffects[effectName])) {
this._effects.push(this._boundEffect(effectDef, effectsConfig[effectName]));
} else {
this._warn(this._logf('_effectsChanged', this._getUndefinedMsg(effectName)));
console.warn(this._getUndefinedMsg(effectName));
}
}
}, this);
Expand Down Expand Up @@ -379,7 +379,7 @@
* @param {string} id The id for the node.
*/
_getDOMRef: function(id) {
this._warn(this._logf('_getDOMRef', '`'+ id +'` is undefined'));
console.warn('_getDOMRef', '`'+ id +'` is undefined');
},

_getUndefinedMsg: function(effectName) {
Expand Down
4 changes: 2 additions & 2 deletions app-scroll-effects/effects/resize-snapped-title.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
var fx = {};

if (!condensedTitle) {
this._warn(this._logf('effects[resize-snapped-title]', 'undefined `condensed-title`'));
console.warn('Scroll effect `resize-snapped-title`: undefined `condensed-title`');
return false;
}
if (!title) {
this._warn(this._logf('effects[resize-snapped-title]', 'undefined `main-title`'));
console.warn('Scroll effect `resize-snapped-title`: undefined `main-title`');
return false;
}

Expand Down
4 changes: 2 additions & 2 deletions app-scroll-effects/effects/resize-title.html
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@
var condensedTitle = this._getDOMRef('condensedTitle');

if (!condensedTitle) {
this._warn(this._logf('effects[resize-title]', 'undefined `condensed-title`'));
console.warn('Scroll effect `resize-title`: undefined `condensed-title`');
return false;
}
if (!title) {
this._warn(this._logf('effects[resize-title]', 'undefined `main-title`'));
console.warn('Scroll effect `resize-title`: undefined `main-title`');
return false;
}

Expand Down

0 comments on commit 3e0d398

Please sign in to comment.