Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use blocking-elements #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use blocking-elements #80

wants to merge 2 commits into from

Conversation

valdrinkoshi
Copy link
Member

@valdrinkoshi valdrinkoshi commented Sep 15, 2016 •
edited
Loading

DO NOT MERGE

Experiment with blockingElements and inert polyfills to take care of focus wrapping.

@frankiefu FYI, PTAL

@valdrinkoshi
Copy link
Member Author

@frankiefu I've updated this to rely on blocking elements only in shop-app, like this each element doesn't have to know the existence of such thing as document.$blockingElements, just expose a way to disable focus alteration, and that's already the case for both app-drawer (via no-trap-focus), and iron-overlay-behavior (indirectly by making it w/o backdrop) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@valdrinkoshi