Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Colorado CDCCs beginning in 2026 #4656

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

xianxinzhu
Copy link
Collaborator

Fixes #4637

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (4390fe5) to head (8a91419).
Report is 8 commits behind head on master.

Current head 8a91419 differs from pull request most recent head 559daab

Please upload reports for the commit 559daab to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4656      +/-   ##
==========================================
+ Coverage   98.97%   99.00%   +0.03%     
==========================================
  Files        2467     2461       -6     
  Lines       35869    35815      -54     
  Branches      184      184              
==========================================
- Hits        35500    35458      -42     
+ Misses        339      327      -12     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PavelMakarchuk
Copy link
Collaborator

image

I think this summary states that two credits are combined into one -> we will need variable adjustments as well I believe

@PavelMakarchuk
Copy link
Collaborator

We currently have 2 vairbales:
co_cdcc.py and co_low_income_cdcc.py

After 2026 this should be just the co_cdcc so we will set the other variable to 0 starting in 2026 (through an in_effect parameter)

- threshold:
2021-01-01: 0
amount:
2021-01-01: 0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think we should have to duplicate the amounts but rather make varying thresholds since it is flat until 2025 if I am reading this correctly

@@ -16,20 +16,24 @@ class co_low_income_cdcc(Variable):
def formula(tax_unit, period, parameters):
# follow 2022 DR 0347 form and its instructions (in Book cited above):
p = parameters(period).gov.states.co.tax.income.credits
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
p = parameters(period).gov.states.co.tax.income.credits
p = parameters(period).gov.states.co.tax.income.credits.cdcc.low_income

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make it 1 for the years before 2026 - would that neutralize the imapct?

# After 2026-01-01, the low-income family child care expenses credit will be combined
# into the child and dependent care credit.
metadata:
label: Colorado low-income family child care expenses credit unified
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add period and unit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify Colorado CDCCs beginning in 2026
2 participants