-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Colorado CDCCs beginning in 2026 #4656
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4656 +/- ##
==========================================
+ Coverage 98.97% 99.00% +0.03%
==========================================
Files 2467 2461 -6
Lines 35869 35815 -54
Branches 184 184
==========================================
- Hits 35500 35458 -42
+ Misses 339 327 -12
Partials 30 30 ☔ View full report in Codecov by Sentry. |
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/adjustment_percentage.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/adjustment_percentage.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/match.yaml
Outdated
Show resolved
Hide resolved
I think this summary states that two credits are combined into one -> we will need variable adjustments as well I believe |
We currently have 2 vairbales: After 2026 this should be just the co_cdcc so we will set the other variable to 0 starting in 2026 (through an |
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/cdcc/low_income/in_effect.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/adjusted_percentage.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/match.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/variables/gov/states/co/tax/income/credits/cdcc/co_low_income_cdcc.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/match.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/states/co/tax/income/credits/eitc/adjusted_percentage.yaml
Outdated
Show resolved
Hide resolved
- threshold: | ||
2021-01-01: 0 | ||
amount: | ||
2021-01-01: 0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should have to duplicate the amounts but rather make varying thresholds since it is flat until 2025 if I am reading this correctly
@@ -16,20 +16,24 @@ class co_low_income_cdcc(Variable): | |||
def formula(tax_unit, period, parameters): | |||
# follow 2022 DR 0347 form and its instructions (in Book cited above): | |||
p = parameters(period).gov.states.co.tax.income.credits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p = parameters(period).gov.states.co.tax.income.credits | |
p = parameters(period).gov.states.co.tax.income.credits.cdcc.low_income |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets make it 1 for the years before 2026 - would that neutralize the imapct?
# After 2026-01-01, the low-income family child care expenses credit will be combined | ||
# into the child and dependent care credit. | ||
metadata: | ||
label: Colorado low-income family child care expenses credit unified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add period and unit
Fixes #4637