New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NJ SNAP minimum allotment #4647

Merged

PavelMakarchuk merged 20 commits into PolicyEngine:master from Kiki-67:Kiki-67/issue4405

Jul 12, 2024

Collaborator

Kiki-67 commented Jun 14, 2024 •

edited by MaxGhenis

Loading


          add parameter and add a separate nj snap file

a14ca68

PavelMakarchuk requested changes

View reviewed changes

policyengine_us/variables/gov/usda/snap/snap.py Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/nj_snap_min_allotment.py Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/nj_snap_min_allotment.py Outdated Show resolved Hide resolved

policyengine_us/parameters/gov/usda/snap/temporary_local_benefit/nj/amount.yaml Outdated Show resolved Hide resolved

policyengine_us/parameters/gov/usda/snap/temporary_local_benefit/nj/amount.yaml Outdated Show resolved Hide resolved

policyengine_us/parameters/gov/usda/snap/temporary_local_benefit/nj/amount.yaml Outdated Show resolved Hide resolved

Kiki-67 added 3 commits

June 19, 2024 19:28


          Merge branch 'Kiki-67/issue4405' of https://github.com/Kiki-67/policy…

5f50ef4

…engine-us; branch 'master' of https://github.com/PolicyEngine/policyengine-us into Kiki-67/issue4405


          merge nj snap to snap_min

afd2214


          format

0ae62b5

PavelMakarchuk requested changes

View reviewed changes

changelog_entry.yaml Outdated Show resolved Hide resolved

policyengine_us/parameters/gov/usda/snap/temporary_local_benefit/nj/in_effect.yaml Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/snap_min_allotment.py Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/snap_min_allotment.py Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/nj_snap_min_allotment.py Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/snap_min_allotment.py Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/snap_min_allotment.py Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/nj_snap_min_allotment.py Outdated Show resolved Hide resolved


          add test

d3bcc98

PavelMakarchuk requested changes

View reviewed changes

changelog_entry.yaml Outdated Show resolved Hide resolved

policyengine_us/parameters/gov/usda/snap/temporary_local_benefit/nj/amount.yaml Outdated Show resolved Hide resolved

policyengine_us/parameters/gov/usda/snap/temporary_local_benefit/nj/amount.yaml Outdated Show resolved Hide resolved

policyengine_us/variables/gov/usda/snap/snap_min_allotment.py Outdated Show resolved Hide resolved

Kiki-67 added 2 commits

June 21, 2024 16:07


          New Jersey SNAP minimum benefit

bf67f61

Fixes PolicyEngine#4405


          update format& change if statement

aecce17

PavelMakarchuk reviewed

View reviewed changes

policyengine_us/variables/gov/usda/snap/snap_min_allotment.py Outdated Show resolved Hide resolved

Kiki-67 added 2 commits

June 28, 2024 06:27


          New Jersey SNAP minimum benefit

1ae3912

Fixes PolicyEngine#4405


          optimize code

33b1dd8

PavelMakarchuk requested changes

View reviewed changes

policyengine_us/parameters/gov/usda/snap/temporary_local_benefit/nj/amount.yaml Outdated Show resolved Hide resolved

PavelMakarchuk reviewed

View reviewed changes

policyengine_us/parameters/gov/usda/snap/temporary_local_benefit/nj/in_effect.yaml Outdated Show resolved Hide resolved

Kiki-67 added 2 commits

July 3, 2024 19:17


          New Jersey SNAP minimum benefit

b26f410

Fixes PolicyEngine#4405


          sync

1e6512e

PavelMakarchuk reviewed

View reviewed changes

policyengine_us/variables/gov/usda/snap/snap_min_allotment.py Show resolved Hide resolved

Kiki-67 added 4 commits

July 3, 2024 20:08


          merge dc+nj min allotment

22d3b3a


          format

323a0a2


          format

3c9c842


          Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us

94e23f1

 into Kiki-67/issue4405

MaxGhenis changed the title ~~add parameter and add a separate nj snap file~~ NJ SNAP minimum allotment

PavelMakarchuk approved these changes

View reviewed changes

PavelMakarchuk marked this pull request as ready for review

July 5, 2024 12:13

PavelMakarchuk requested a review from MaxGhenis

July 5, 2024 12:13

MaxGhenis requested changes

View reviewed changes

policyengine_us/tests/policy/baseline/gov/usda/snap/snap_min_allotment.yaml Outdated

               - name: DC provides a different minimum allotment amount
-                period: 2024-01
+                period: 2024

Contributor

MaxGhenis Jul 5, 2024

Can we keep the period as a month? For monthly variables it better aligns with our minimalist approach. Please change others in this file too.

Contributor

MaxGhenis Jul 5, 2024

Please change others in this file too.


          change to month period

91c9531

Kiki-67 requested a review from MaxGhenis

July 5, 2024 16:49


          sync

3bccc26

Kiki-67 added 2 commits

July 11, 2024 03:43


          change to month

e1354e4


          Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us

fa6898f

 into Kiki-67/issue4405

Contributor

MaxGhenis commented Jul 11, 2024

Pull again - too many changes


          Merge branch 'master' of https://github.com/PolicyEngine/policyengine-us

ed45ada

 into Kiki-67/issue4405

MaxGhenis approved these changes

View reviewed changes

PavelMakarchuk merged commit 54cddfa into PolicyEngine:master

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet