Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improved testing #2021

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Fix/improved testing #2021

wants to merge 14 commits into from

Conversation

anth-volk
Copy link
Collaborator

Fixes #2015
Partially fixes #2013 (some tests will need to be broken up into relevant files)
Fixes #2007
Fixes #1357

Inspired by #2010 (a regression introduced by #2006), this PR creates a new testing structure for economy-wide simulations. The aim is to make it simple to test that a series of common reform impacts (e.g., modifying the federal income tax rate) still runs and returns values within reason for certain key measures. This does not compare outputs with country packages (that's open as #2017, but it's unclear if its likely slow pace would justify writing it).

This also begins to move toward a more concise testing folder structure, whereby integration tests (any that hit use the rest_client Pytest fixture to simulate an endpoint hit, then check its response) are distinct from unit tests. A few tests are either also being modified in an open PR or would need to be subdivided to match the internal file structure, so they've been relegated to a temporary to_be_refactored folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant