Add Numberless Energy set data #516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there are a few duplicate cards in the Sun and Moon block, since this api put half of the unnumbered basic energies from that block in sm1. @adback03 what would be the best way to address this? |
Fixed json structure of sets/en.json
|
Due to discoveries involving PTCGL, and PTCGO being inconsistent with it's own numbering, I decided to again use type letters for card IDs based on the logic that as there is no correct way to number the numberless energy, it should be up to the programmer to convert it to their needs |
|
https://drive.google.com/file/d/18Bz2hPBj7KTm4qLBlmO_jXruvZaI8FEQ/view?usp=sharing a link to the image files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 2 of #260 , with some changes to bring things in line with PTCGO decklist exports.
Images exist in the old PR but need re-sorting, all numberless energy should be accounted for now.
Compared to the old PR this PR uses numbers for the energy, like PTCGO decklists do, and gives them codes which they had, or for older sets some in the same style as the ones that existed. Also like PTCGO, where 2 energy sets appeared in a gen they were merged into a single set with the second art counting after the first.