Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCD23 for match battle 2023 #481

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tkfnetwork
Copy link

@tkfnetwork tkfnetwork commented Sep 15, 2023

This PR adds the McDonalds 2023 collection.

Not sure the process for images?

@Cealgair
Copy link
Contributor

I think you should add the expanded and unlimited legalities to each card and to the set. Otherwise, great job!

@tkfnetwork
Copy link
Author

I think you should add the expanded and unlimited legalities to each card and to the set. Otherwise, great job!

Ah ok, I was only able to find information saying that standard was legal. Do we assume expanded and unlimited are legal until told otherwise? Is there a state for that, or the absence of the property is indication? Thanks in advance!

@Cealgair
Copy link
Contributor

Do we assume expanded and unlimited are legal until told otherwise?

For unlimited: yes, the only cards that are not currently marked as unlimited legal are the ones that have a rule printed on them saying that they cannot be played in tournaments.

For expanded, I'd say that if a card has a regulation mark and is not banned, then it should be expanded legal. And besides, these cards are reprints of cards that we already know to be expanded legal anyway.

@tkfnetwork
Copy link
Author

Do we assume expanded and unlimited are legal until told otherwise?

For unlimited: yes, the only cards that are not currently marked as unlimited legal are the ones that have a rule printed on them saying that they cannot be played in tournaments.

For expanded, I'd say that if a card has a regulation mark and is not banned, then it should be expanded legal. And besides, these cards are reprints of cards that we already know to be expanded legal anyway.

Fantastic, thanks for explaining! Have updated in ea38968

@jparanada
Copy link

Regarding images, here they are (733x1024, and the same ones PkmnCards will use): https://cdn.malie.io/file/malie-io/art/scans/submissions/m23_en.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants