Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Poké Card Creator Pack #377

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Cealgair
Copy link
Contributor

@Cealgair Cealgair commented Feb 28, 2023

Basically, I noticed from Bulbapedia that this set was missing. I did my best to try to add it. Here's a list of things I'm not sure I did right:

  • I chose "pccp" as the id for this set I changed it to "cc" because it's the set abbreviation used by Bulbapedia. I don't know why they chose that abbreviation but I figured I should use the same one
  • I omitted the ptcgoCode
  • I chose "Other" for the series, arguably one should choose "EX"
  • I put "2004/07/01" as the release date. Bulbapedia only says the month of release, not the day.
  • I put "2023/02/28 00:00:00" for updatedAt
  • I put the rule "NOT TOURNAMENT LEGAL" on each card, since it is on the cards themselves and it's in all caps on the cards
  • I put "unlimited": "Banned" for the legalities (both for the set and for the cards). See issue Legality of cards that are not legal nor banned in any format #247

I hope the images can be found using the link to Bulbapedia I provided above, and that they're good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant