Skip to content

Commit

Permalink
Cannot pass the string 'playtechnique' into a job output.
Browse files Browse the repository at this point in the history
This is because it's also my docker hub username. Go figure.
  • Loading branch information
gwynforthewyn committed Jun 2, 2024
1 parent e9dd034 commit 45d370e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/publish_website_docker_image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,8 @@ jobs:
id: set-docker-image
run: |
echo ${{ env.DOCKERIMAGE }}
echo "dockerimage=${{ env.DOCKERIMAGE }}" >> ${GITHUB_OUTPUT}
- uses: actions/checkout@v4
release-to-production:
uses: ./.github/workflows/release_website.yaml
needs: build
with:
docker-image: ${{needs.build.outputs.dockerimage}}
docker-image-tag: ${{ github.run_number }}
7 changes: 4 additions & 3 deletions .github/workflows/release_website.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ on:
- 'website/k8s-manifests/overlays/**'
workflow_call:
inputs:
docker-image:
description: 'Docker image plus tag to udpate to'
docker-image-tag:
description: 'Docker tag to udpate to'
required: true
type: string

jobs:
update-container-version-patch:
runs-on: ubuntu-latest
Expand All @@ -26,7 +27,7 @@ jobs:
- name: edit file
run: |
yq e '.spec.template.spec.containers[0].image = "${{ inputs.docker-image }}"' -i website-deployment/k8s-manifests/overlays/production/deployment-container-version-patch.yaml
yq e '.spec.template.spec.containers[0].image = "docker.io/playtechnique/website:${{ inputs.docker-image-tag }}"' -i website-deployment/k8s-manifests/overlays/production/deployment-container-version-patch.yaml
- name: commit back to github
run: |
Expand Down

0 comments on commit 45d370e

Please sign in to comment.