Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from 1Hive/aragon #15

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Merge from 1Hive/aragon #15

wants to merge 18 commits into from

Conversation

danimesq
Copy link
Member

Should support XDai (network) and WalletConnect (login method)

@danimesq danimesq added the enhancement New feature or request label Oct 23, 2021
@danimesq danimesq self-assigned this Oct 23, 2021
@@ -4,7 +4,7 @@ import Aragon, {
ensResolve,
getRecommendedGasLimit,
providers,
} from '@aragon/wrapper'
} from '@1hive/wrapper'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

@@ -4,7 +4,7 @@ import Aragon, {
ensResolve,
getRecommendedGasLimit,
providers,
} from '@aragon/wrapper'
} from '@1hive/wrapper'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

@@ -4,7 +4,7 @@ import Aragon, {
ensResolve,
getRecommendedGasLimit,
providers,
} from '@aragon/wrapper'
} from '@1hive/wrapper'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

{ id: 'provided' },
{ id: 'frame' },
portisDappId ? { id: 'portis', conf: portisDappId } : null,
].filter(p => p),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

@@ -4,7 +4,7 @@ import Aragon, {
ensResolve,
getRecommendedGasLimit,
providers,
} from '@aragon/wrapper'
} from '@1hive/wrapper'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

{ id: 'provided' },
{ id: 'frame' },
portisDappId ? { id: 'portis', conf: portisDappId } : null,
].filter(p => p),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

return 0
})
}, [selectorNetworks])

const changeNetwork = useCallback(
index => {
const networkType = selectorNetworksSorted[index].type
const networkConfig = getNetworkConfig(networkType)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.
Too many errors. (27% scanned).

return 0
})
}, [selectorNetworks])

const changeNetwork = useCallback(
index => {
const networkType = selectorNetworksSorted[index].type
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
Missing semicolon.

if (b.type === network.type) return 1
if (a.type === network.type) return -1
if (b.chainId === network.chainId) return 1
if (a.chainId === network.chainId) return -1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

.sort((a, b) => {
if (b.type === network.type) return 1
if (a.type === network.type) return -1
if (b.chainId === network.chainId) return 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

@@ -24,16 +26,21 @@ const Welcome = React.memo(function Welcome({

const selectorNetworksSorted = useMemo(() => {
return selectorNetworks
.map(([type, name, url]) => ({ type, name, url }))
.map(([chainId, type, name, url]) => ({ chainId, type, name, url }))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).


import actionCreate from './assets/action-create.png'
import actionOpen from './assets/action-open.png'
import { getNetworkConfig } from '../../network-config'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

@@ -7,9 +7,11 @@ import Header from '../Header/Header'
import OpenOrg from './OpenOrg'
import Suggestions from './Suggestions'
import WelcomeAction from './WelcomeAction'
import { setDefaultEthNode, setEthNetworkType } from '../../local-settings'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

@@ -1,5 +1,5 @@
import PropTypes from 'prop-types'
import Aragon from '@aragon/wrapper'
import Aragon from '@1hive/wrapper'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'import' is only available in ES6 (use 'esversion: 6').
Missing semicolon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants