-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev fix compiler warning #3455
Open
icathychen
wants to merge
3
commits into
PixarAnimationStudios:dev
Choose a base branch
from
icathychen:dev_fixCompilerWarning
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev fix compiler warning #3455
icathychen
wants to merge
3
commits into
PixarAnimationStudios:dev
from
icathychen:dev_fixCompilerWarning
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome. Thanks, @icathychen ! |
Filed as internal issue #USD-10499 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, how does the merge process work now that the test is ran successfully? |
It gets added to Pixar’s queue to verify everything works with their
internal version of USD and then merged in once they have run their
internal test suites.
…On Mon, Dec 9, 2024 at 3:42 PM Cathy Chen ***@***.***> wrote:
Hi, how does the merge process work now that the test is ran successfully?
—
Reply to this email directly, view it on GitHub
<#3455 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABB4XUXCS2IEYJLP76RKG432EYTE3AVCNFSM6AAAAABTDWB67WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRZG44TIOJVGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fixes Issue(s)
Checklist
[x] I have created this PR based on the dev branch
[x] I have followed the coding conventions
[x] I have added unit tests that exercise this functionality (Reference:
testing guidelines)
[x] I have verified that all unit tests pass with the proposed changes
[x] I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)