Fix UsdGeomPointInstancer ComputeExtents when prototypes are under an over #3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…over Fixes PixarAnimationStudiosGH-3395. As described at https://openusd.org/docs/api/class_usd_geom_point_instancer.html#UsdGeomPointInstancer_protoProcessing PointInstancers can define prototypes under a parent prim specified as an over. The ComputeExtent plugin registered for PointInstancer was not correctly computing prototype bboxes in this case. This extends UsdGeomBBoxCache to allow for a custom prim predicate to be passed, which the updated ComputeExtent plugin takes advantage of to traverse prototype prims in this case.
cbillingham
commented
Nov 4, 2024
| @@ -439,7 +465,7 @@ UsdGeomBBoxCache::_ComputeBoundWithOverridesHelper( | |||
| } | |||
|
|
|||
| GfBBox3d result; | |||
| UsdPrimRange range(prim); | |||
| UsdPrimRange range(prim, _primPredicate); | |||
There was a problem hiding this comment.
I was a bit unsure about this change. Looking at where this is called, it seemed to me that this should be following the same predicate as the other traversals, but it was not before. Let me know if I need to roll this back
|
I took a stab at addressing this, but let me know if I went down the the wrong path |
|
Filed as internal issue #USD-10392 ❗ Please make sure that a signed CLA has been submitted! |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I should have one sent in Feb 2021. Let me know if I need to send in a new one |
|
Thank you for flagging that! We have your CLA on file; so sorry for the confusion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Allow UsdGeomBBox to take in a custom prim traversal predicate so that UsdGeomPointInstancer can compute bboxes of prototypes that exist under an over as described by the docs
Fixes Issue(s)
#3395
Checklist
testing guidelines)
Contributor License Agreement instructions)