Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example modal js package fix #92

Merged
merged 3 commits into from
Sep 15, 2023
Merged

example modal js package fix #92

merged 3 commits into from
Sep 15, 2023

Conversation

Templarian
Copy link
Collaborator

Proposed Changes

Fixes the example modals to reference the correct JS package.

Types of Changes

What types of changes does your code introduce?

  • Documentation Update
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the Contributing doc.
  • Lint passes locally with my changes.
  • I have added necessary documentation (if appropriate).

Additional Information

@Templarian Templarian added the Bug Something isn't working as expected label Sep 15, 2023
@Templarian Templarian self-assigned this Sep 15, 2023
@Templarian Templarian merged commit 8f208e2 into main Sep 15, 2023
2 checks passed
@Templarian Templarian deleted the fix-npm-js branch September 15, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mririgoyen mririgoyen mririgoyen approved these changes

Assignees

@Templarian Templarian

Labels
Bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Templarian @mririgoyen