Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades and split into three OS versions #40

Merged
merged 43 commits into from
Jul 26, 2023
Merged

Conversation

DieterHolz
Copy link
Contributor

No description provided.

@FDelporte
Copy link
Member

@DieterHolz you're fast ;-)

base/base.sh Outdated Show resolved Hide resolved
base/base.sh Outdated Show resolved Hide resolved
base/base.sh Outdated Show resolved Hide resolved
base/base.sh Outdated Show resolved Hide resolved
base/base.sh Outdated Show resolved Hide resolved
base/base.sh Outdated Show resolved Hide resolved
base/base.sh Outdated Show resolved Hide resolved
base/base.sh Outdated Show resolved Hide resolved
@FDelporte FDelporte changed the title upgrade to pi4j 2.2.0 Upgrades and split into three OS versions Jun 26, 2023
@FDelporte
Copy link
Member

Shouldn't the crowpi example project be included in https://github.com/Pi4J/pi4j-os/tree/upgrade-jdk18-jfx18/crowpi/resources ?

@DieterHolz
Copy link
Contributor Author

Shouldn't the crowpi example project be included in https://github.com/Pi4J/pi4j-os/tree/upgrade-jdk18-jfx18/crowpi/resources ?

Yes, of course.

Will fix it.

@DieterHolz
Copy link
Contributor Author

Now, after double-checking CrowPiOS, I'm not really sure what you mean with "Shouldn't the crowpi example project be included".

First, I assumed that "HelloFX" and "MinimalPi4J" is missing. But they are included.

@FDelporte
Copy link
Member

@DieterHolz
Copy link
Contributor Author

My previous opinion was that we should push our students towards using their laptops as developer machine and the Pi for running the apps only.

Therefore I would not include the crowpi-example project in CrowPiOS.

If you really want to use it directly on Pi, it's only a single git clone away.

The READMEs of cropwpi-examples and Pi4J-OS needs to be adjusted, accordingly.

But maybe it's time to do things differently ....

@FDelporte
Copy link
Member

Therefore I would not include the crowpi-example project in CrowPiOS.

valid point!

@FDelporte FDelporte self-requested a review July 26, 2023 09:59
@DieterHolz DieterHolz merged commit c1dc8fd into main Jul 26, 2023
8 checks passed
@DieterHolz DieterHolz deleted the upgrade-jdk18-jfx18 branch July 26, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants