Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pi 5 enum to PiVersion #999

Closed
wants to merge 1 commit into from

Conversation

Technologyman00
Copy link
Contributor

Added Pi 5 to Pi Version. It deviates a bit from previous pi versions as there is no model, but it should work the same

compatible = "raspberrypi,5-model-b", "brcm,bcm2712"; model = "Raspberry Pi 5";

@Technologyman00 Technologyman00 requested a review from a team as a code owner November 5, 2023 18:21
@mcm001
Copy link
Contributor

mcm001 commented Nov 5, 2023

Sick. Can you try the JAR out on a pi 5 and post the startup output from this print? I'd expect it to pick it up here:

        logger.info(
                "Starting PhotonVision version "
                        + PhotonVersion.versionString
                        + " on "
                        + Platform.getPlatformName()
                        + (Platform.isRaspberryPi() ? (" (Pi " + PiVersion.getPiVersion() + ")") : ""));

@BytingBulldogs3539
Copy link
Contributor

Made the exact same change in our repo at the same time but this is what it reads.
[General - Main] [INFO] Starting PhotonVision version dev-v2024.1.1-beta-3-3-gbef82fa6 on Linux Raspbian 64-bit (Pi PI_5)

@mcm001
Copy link
Contributor

mcm001 commented Nov 9, 2023

Needs lint fixed

@mcm001 mcm001 closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants