Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Reorgranize CI tasks into their own files #953

Merged
merged 10 commits into from
Oct 16, 2023
Merged

[NFC] Reorgranize CI tasks into their own files #953

merged 10 commits into from
Oct 16, 2023

Conversation

srimanachanta
Copy link
Member

closes #950

@mcm001
Copy link
Contributor

mcm001 commented Oct 15, 2023

Did the old CI system block tasks if lint failed? IDR. If no, lgtm

@srimanachanta srimanachanta marked this pull request as ready for review October 15, 2023 20:32
@srimanachanta srimanachanta requested a review from a team as a code owner October 15, 2023 20:32
@srimanachanta
Copy link
Member Author

Needs to change the jobs that are required for PR merge.
photon-build-all -> build-gradle
photonclient-build -> build-client
photonserver-check-lint & wpiformat -> wpiformat, javaformat, server-index, & client-lint-format

@mcm001 mcm001 merged commit 4e5e806 into PhotonVision:master Oct 16, 2023
21 checks passed
mcm001 pushed a commit to mcm001/photonvision that referenced this pull request Oct 16, 2023
@srimanachanta @mcm001
[NFC] Reorgranize CI tasks into their own files (PhotonVision#953)
cd83e22 
Closes PhotonVision#950
@srimanachanta srimanachanta deleted the organize-ci branch October 17, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename spotlessCheck CI
2 participants
@srimanachanta @mcm001