Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false-positive vision estimation edgecase #932

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

amquake
Copy link
Member

@amquake amquake commented Oct 7, 2023

Reported by @prensing

there is a problem if the found tags are a valid one plus an invalid tag, so eg it sees a tag but finds noise on the wall, and so lists tags 2 and 15. Lines 90-99 will ignore tag 15, and put 4 corners into the list. It will get past the test on line 100 (there are 4 corners). BUT then at line 106, there are 2 entries in visTags, so it will go to the "else" and try to use solvePNP_SQPNP().

@amquake amquake requested a review from a team as a code owner October 7, 2023 02:52
@mcm001
Copy link
Contributor

mcm001 commented Oct 8, 2023

We ball

@mcm001 mcm001 merged commit 2881741 into PhotonVision:master Oct 8, 2023
20 checks passed
@mcm001 mcm001 deleted the visionest-fix branch October 8, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants