Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Java Simulation Examples #913

Merged
merged 53 commits into from
Oct 5, 2023
Merged

Update Java Simulation Examples #913

merged 53 commits into from
Oct 5, 2023

Conversation

amquake
Copy link
Member

@amquake amquake commented Sep 20, 2023 •
edited
Loading

Updates java examples to use new simulation framework.

New examples readme

Removes apriltagExample and simposeest, replacing them with swervedriveposeestsim which is:

A minimal swerve drive example demonstrating the usage of PhotonVision for AprilTag vision estimation with a swerve drive pose estimator.

The example also has simulation support with an approximation of swerve drive dynamics.

amquake and others added 30 commits June 19, 2023 21:16
@amquake
optional pnp results, pnp method simplification
4c2aa16
@amquake
solvepnp docs clarification
209e184
@amquake
spotless
b4a0c90
@amquake
fix local tag image loading
1511b2a
@amquake
solvepnp square NaN retry
5be4557
@amquake
spotless
c9d2f1e
@mcm001
Merge branch 'master' into 742-robustness
2ea3453
@amquake
Merge branch 'master' into 742-robustness
c7cc564
@amquake
use condition in result instead of Optional
6b22823
@amquake
publish sim intrinsics/distortion to camera
4364ac2
@amquake
spotless
1f03b96
@amquake
Merge branch 'master' of https://github.com/PhotonVision/photonvision …
ca49c23 
…into sim-draw-targets
@amquake
remember to commit, me
2e851a0
@amquake
spotless
a6eec79
@amquake
fix tests using target yaw/pitch
c270828
@amquake
spotless
423712b
@amquake
fix culled polygons joining, video sim tweaks
c15f784
@amquake
dont do SQPNP on non-tag targets
61b037d
@amquake
non-square target points bugfix
e8a0820
@amquake
cuboid target model
08bc306
@amquake
standardize image operations on Point class
bb1b8a4
@amquake
spotless
a084abc
@amquake
draw minarearect
8885514
@amquake
update apriltag example
24bf9ff
@amquake
oops
76eb0f3
@amquake
fix calculated center pt
74f1582
@amquake
revert docs note
4c99b78
@amquake
update wireframe dimensions
8f1eb32
@amquake
Merge branch 'master' into sim-draw-targets
dc5d12c
@amquake
init
c9a3a67
@amquake amquake requested a review from a team as a code owner September 20, 2023 03:37
@amquake amquake changed the title Update Simulation Examples Update Java Simulation Examples Sep 20, 2023
@amquake
Copy link
Member Author

amquake commented Sep 20, 2023

Should the example descriptions be duplicated to their individual folders (is there a nicer way to do that?) or is it fine as is?

@amquake amquake mentioned this pull request Sep 20, 2023
Merged
@mcm001
Copy link
Contributor

mcm001 commented Sep 23, 2023

Readme is fine as is, I think! Could you add keybindings for buttons to the readme too? so like "button A does X" or "enabling auto does Y"

@mcm001
Copy link
Contributor

mcm001 commented Sep 24, 2023

Readme is fine as is, I think! Could you add keybindings for buttons to the readme too? so like "button A does X" or "enabling auto does Y"

I'm blind, those exist, just not for old existing examples. That can be addressed later

mcm001
mcm001 reviewed Sep 24, 2023
View reviewed changes
photonlib-cpp-examples/README.md

Build photonvision and publish it locally with:
For instructions on how to run these examples locally, see [Running Examples](https://docs.photonvision.org/en/latest/docs/contributing/photonvision/build-instructions.html#running-examples).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For docs PR: this list will need to be updated
image

@srimanachanta
Copy link
Member

Does this close #700? I'm assuming we no longer have a requirement for a SimPoseEstimator?

@mcm001 mcm001 mentioned this pull request Sep 26, 2023
Closed
@mdurrani808 mdurrani808 added this to the 2024 Beta milestone Sep 26, 2023
@mcm001 mcm001 merged commit ce0d28d into PhotonVision:master Oct 5, 2023
20 checks passed
@amquake amquake mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2024 Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@amquake @mcm001 @srimanachanta @mdurrani808