Advanced networking settings #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
changed the title
srimanachanta
requested changes
Aug 24, 2023
| const saveGeneralSettings = () => { | ||
| const changingStaticIp = useSettingsStore().network.connectionType === NetworkConnectionType.Static; | ||
| const changingStaticIp = |
There was a problem hiding this comment.
Figure out code formatting for one line statements
| @@ -82,12 +85,11 @@ export const useSettingsStore = defineStore("settings", { | |||
| this.network = data.networkSettings; | |||
| }, | |||
| saveGeneralSettings() { | |||
There was a problem hiding this comment.
This should likely be renamed to save network settings in both the front and backend as it is only ever used for network settings due to general settings being read-only and lighting being handled by the websocket.
There was a problem hiding this comment.
cursed that it's split up like that
There was a problem hiding this comment.
Probably best to handle in another PR
|
I'm confused, why CI is failing? This PR doesn't touch photon-lib |
|
I agree it's weird. Re running |
srimanachanta
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes physicalInterface from NetworkConfig, we can get it by looking it up in the list of NetworkManager interfaces instead. Exposes managed NetworkManager interface in the UI.
Add disable-networking and clear-config command line opts
Don't love the UI yet, idk.